This repository has been archived by the owner on Jan 14, 2018. It is now read-only.
Remove code duplication from RetrofitObjectPersister.loadDataFromCache and instead use readCacheDataFromFile. #138
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove code duplication. RetrofitObjectPersister's base class, InFileObjectPersister, already handles cache hit checking. Move relevant code to RetrofitObjectPersister.readCacheDataFromFile, which is called on cache hit. The only change of behavior is that the retrofit reimplementation logged cache misses.
Also fixed RetrofitSpiceTestService which was failing because the server url was empty.