FIXED ConcurrentModificationException when adding a request listener to a request that's firing updates

[softwaremaverick]

No description provided.

[stephanenicolas]

Really nice piece of code. Personnally, I don't know how to unit test something like this in a predictible way.

You have any test to submit, please go ahead. Eager to see other patches, this one is really neat.

[softwaremaverick]

Thanks. I fix them as I find them.

[softwaremaverick]

Oh and as for unit testing it. I imagine that two threads running where one is iterating over the request listeners but where a request listener is purposely slow, whilst another addListenerIfPending request is happening should pretty much do it.

[stephanenicolas]

I agree but that would not be predictable. Multiple loops (I mean a large
one with many iterations) could help to get more "predictable"...

The best way could that a listener that is being fired itself modifies the
list of listeners it belongs to. That would get predictable.
WDYT ?

2013/7/11 softwaremaverick [email protected]

Oh and as for unit testing it. I imagine that two threads running where
one is iterating over the request listeners but where a request listener is
purposely slow, whilst another addListenerIfPending request is happening
should pretty much do it.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/140#issuecomment-20841491
.

Stéphane NICOLAS,
OCTO Technology
Développeur & Consultant Android / Java
..........................................................
50, Avenue des Champs-Elysées
75008 Paris
+33 (0)6.26.32.34.09
www.octo.com - blog.octo.com
www.usievents.com
...........................................................