This repository has been archived by the owner on Jan 14, 2018. It is now read-only.
Remove unbinding before removing listeners #317
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…moveUnbindingBeforeRemovingListeners
|
Hi Vselod (@seva-ask), would you mind to squash all your commits into one and make all checks and tests pass and resubmit please ? I saw this rule on other projects, namely on Square's, squashing feature branches as single commits really makes merger life much more easy. The PR is marked as invalid until all tests pass, but it is planned for next release. S. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added a test for #302.
It fails without my fix very often, but it depends on system and processor cores load.
I think that I can't write a test that fails in 100% of runs because bug is not reproducible when spicemanager thread is running on same processor core as main thread.
Actually, I wouldn't have been working on this issue if I hadn't faced it in my real project. I have a crash when I click back button many times fast, which causes spicemanagers be stopped right after they were queued some requests to execute.