fixed NPE when cache folder is empty

[skhanzada]

InFileObjectPersister throws NPE from line 112

    List<Object> result = new ArrayList<Object>(cacheFileNameList.length);

The problem is with the 'cacheFileNameList' array that is returned from the following line

String[] cacheFileNameList = getCacheFolder().list(new FilenameFilter() {

if this array is null which could be true in some situations than a NPE is thrown on line 112.

It can be reproduced by clearing app cache from settings and try to use the app, you will see app crash.

[jtietema]

@stephanenicolas Any change this can be merged? The failed build seems pretty random, something about Maven not being able to download the findbugs dependency. Doesn't seem related to the PR...

[stephanenicolas]

Hi @jtietema , sorry but the patch completely escaped my scope. We thought to go for a 1.5.0 release but it looks like we had less time than we thought for this release yet. Personally, I am completely in something else for now.

So, the solution might be to refork from the last stable version a version 1.4.14, including the patch. I will see what I can do in the next few days. I hope this is fine for you. Thanks to @jtietema and @skhanzada for submitting the patch.

Stéphane

[stephanenicolas]

Thx. This has been merged. 1.4.14 should be released within hours.

[stephanenicolas]

RS 1.4.14 is released and should hit central within 2 hours. Thx for your contributions.

[jtietema]

Awesome! Thanks for the release :-)