⚡ Split js in two files (application.js and game_page.js) (#184)

stephannv · Sep 2, 2022 · fe1a4cd · fe1a4cd
1 parent b0eddaa
commit fe1a4cd
Show file tree

Hide file tree

Showing 5 changed files with 18 additions and 6 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -73,6 +73,11 @@ jobs:
       - name: Install Yarn packages
         run: yarn install --check-files --pure-lockfile
 
+      - name: Compile Assets
+        run: |
+          bin/rails css:build
+          bin/rails javascript:build
+
       - name: Create database structure
         run: RAILS_ENV=test bundle exec rails db:reset
 

diff --git a/app/javascript/controllers/index.js b/app/javascript/controllers/index.js
@@ -4,14 +4,8 @@
 
 import { application } from "./application"
 
-import ItemThumbnailsController from "./item_thumbnails_controller.js"
-application.register("item-thumbnails", ItemThumbnailsController)
-
 import MoneyInputController from "./money_input_controller.js"
 application.register("money-input", MoneyInputController)
 
-import PriceHistoryChartController from "./price_history_chart_controller.js"
-application.register("price-history-chart", PriceHistoryChartController)
-
 import SortSelectController from "./sort_select_controller.js"
 application.register("sort-select", SortSelectController)
diff --git a/app/javascript/game_page.js b/app/javascript/game_page.js
@@ -0,0 +1,7 @@
+import { application } from "controllers/application"
+
+import ItemThumbnailsController from "controllers/item_thumbnails_controller.js"
+application.register("item-thumbnails", ItemThumbnailsController)
+
+import PriceHistoryChartController from "controllers/price_history_chart_controller.js"
+application.register("price-history-chart", PriceHistoryChartController)
diff --git a/app/pages/games/show_page.html.erb b/app/pages/games/show_page.html.erb
@@ -2,6 +2,10 @@
 
 <% content_for :page_title, game.title %>
 
+<% content_for :head do %>
+  <%= javascript_include_tag "game_page", defer: true, "data-turbo-track": "reload" %>
+<% end %>
+
 <div class="w-full flex justify-center pb-4">
   <div class="w-full md:w-4/5 lg:w-3/4 xl:w-1/2 flex flex-col gap-4">
     <%= render ItemDetails::ThumbnailsSectionComponent.new(item: game) %>

diff --git a/app/views/layouts/application.html.erb b/app/views/layouts/application.html.erb
@@ -14,6 +14,8 @@
     <% if Rails.env.production? %>
       <script data-domain="nindika.com" src="https://analytics.nindika.com/js/plausible.js" async defer></script>
     <% end %>
+
+    <%= yield :head %>
   </head>
 
   <body>