Skip to content

Commit

Permalink
Remove buildkite configs and references (temporalio#5467)
Browse files Browse the repository at this point in the history
## What changed?
<!-- Describe what has changed in this PR -->
Remove buildkite configs and references.

## Why?
<!-- Tell your future self why have you made these changes -->
Buildkite is no longer used.

## How did you test it?
<!-- How have you verified this change? Tested locally? Added a unit
test? Checked in staging env? -->
Existing tests.

## Potential risks
<!-- Assuming the worst case, what can be broken when deploying this
change to production? -->
No.

## Documentation
<!-- Have you made sure this change doesn't falsify anything currently
stated in `docs/`? If significant
new behavior is added, have you described that in `docs/`? -->
N/A

## Is hotfix candidate?
<!-- Is this PR a hotfix candidate or does it require a notification to
be sent to the broader community? (Yes/No) -->
No.
  • Loading branch information
rodrigozhou authored Mar 1, 2024
1 parent 849fb7b commit c236596
Show file tree
Hide file tree
Showing 12 changed files with 8 additions and 1,495 deletions.
15 changes: 1 addition & 14 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ bins: temporal-server temporal-cassandra-tool temporal-sql-tool tdbg
# Install all tools, recompile proto files, run all possible checks and tests (long but comprehensive).
all: update-tools clean proto bins check test

# Used by Buildkite.
# Used in CI
ci-build-misc: print-go-version ci-update-tools proto bins shell-check copyright-check go-generate gomodtidy ensure-no-changes

# Delete all build artifacts
Expand Down Expand Up @@ -44,9 +44,6 @@ ifdef TEST_TAG
override TEST_TAG := -tags $(TEST_TAG)
endif

export TEST_TOTAL_SHARDS ?= $(BUILDKITE_PARALLEL_JOB_COUNT)
export TEST_SHARD_INDEX ?= $(BUILDKITE_PARALLEL_JOB)

##### Variables ######

GOBIN := $(if $(shell go env GOBIN),$(shell go env GOBIN),$(GOPATH)/bin)
Expand Down Expand Up @@ -383,11 +380,6 @@ coverage-report: $(SUMMARY_COVER_PROFILE)
@printf $(COLOR) "Generate HTML report from $(SUMMARY_COVER_PROFILE) to $(SUMMARY_COVER_PROFILE).html..."
@go tool cover -html=$(SUMMARY_COVER_PROFILE) -o $(SUMMARY_COVER_PROFILE).html

ci-coverage-report: $(SUMMARY_COVER_PROFILE) coverage-report
@printf $(COLOR) "Generate Coveralls report from $(SUMMARY_COVER_PROFILE)..."
go install github.com/mattn/[email protected]
@goveralls -coverprofile=$(SUMMARY_COVER_PROFILE) -service=buildkite || true

##### Schema #####
install-schema-cass-es: temporal-cassandra-tool install-schema-es
@printf $(COLOR) "Install Cassandra schema..."
Expand Down Expand Up @@ -516,16 +508,11 @@ update-dashboards:
gomodtidy:
@printf $(COLOR) "go mod tidy..."
@go mod tidy
@$(MAKE) update-third-party-deps

update-dependencies:
@printf $(COLOR) "Update dependencies..."
@go get -u -t $(PINNED_DEPENDENCIES) ./...
@go mod tidy
@$(MAKE) update-third-party-deps

update-third-party-deps:
@GOOS=linux GOARCH=amd64 go list -deps $(FUNCTIONAL_TEST_ROOT) | sort -u | grep '^[a-z]\+\.[a-z.]\+/' | grep -v go.temporal.io > develop/buildkite/third_party_deps.txt

go-generate:
@printf $(COLOR) "Process go:generate directives..."
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
[![Build status](https://badge.buildkite.com/98c157ed502d55722ef7f28e6470aa20702c76d6989a0a5a89.svg?branch=main)](https://buildkite.com/temporal/temporal-public)
[![Build status](https://github.com/temporalio/temporal/actions/workflows/run-tests.yml/badge.svg?branch=main)](https://github.com/temporalio/temporal/commits/main/)
[![Coverage Status](https://coveralls.io/repos/github/temporalio/temporal/badge.svg?branch=main)](https://coveralls.io/github/temporalio/temporal?branch=main)
[![Discourse](https://img.shields.io/static/v1?label=Discourse&message=Get%20Help&color=informational)](https://community.temporal.io)
[![Go Report Card][go-report-image]][go-report-url]
Expand Down
23 changes: 6 additions & 17 deletions common/persistence/tests/postgresql_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -176,23 +176,12 @@ func (p *PostgreSQLSuite) TestPostgreSQLClusterMetadataPersistence() {
suite.Run(p.T(), s)
}

// TODO flaky test in buildkite
// https://go.temporal.io/server/issues/2877
/*
FAIL: TestPostgreSQLQueuePersistence/TestNamespaceReplicationQueue (0.26s)
queuePersistenceTest.go:102:
Error Trace: queuePersistenceTest.go:102
Error: Not equal:
expected: 99
actual : 98
Test: TestPostgreSQLQueuePersistence/TestNamespaceReplicationQueue
*/
// func (p *PostgreSQLSuite) TestPostgreSQLQueuePersistence() {
// s := new(persistencetests.QueuePersistenceSuite)
// s.TestBase = persistencetests.NewTestBaseWithSQL(persistencetests.GetPostgreSQLTestClusterOption())
// s.TestBase.Setup(nil)
// suite.Run(p.T(), s)
// }
func (p *PostgreSQLSuite) TestPostgreSQLQueuePersistence() {
s := new(persistencetests.QueuePersistenceSuite)
s.TestBase = persistencetests.NewTestBaseWithSQL(persistencetests.GetPostgreSQLTestClusterOption())
s.TestBase.Setup(nil)
suite.Run(p.T(), s)
}

// SQL store tests

Expand Down
22 changes: 0 additions & 22 deletions develop/buildkite/Dockerfile

This file was deleted.

58 changes: 0 additions & 58 deletions develop/buildkite/README.md

This file was deleted.

Loading

0 comments on commit c236596

Please sign in to comment.