Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[watermark] Fix error: BUFFER_POOL_WATERMARK isn't enabled by default #41

Closed
wants to merge 2 commits into from

Conversation

stephenxs
Copy link
Owner

- Why I did it
Fix error: watermarkstat -t buffer_pool doesn't work

- How I did it

- How to verify it

- Description for the changelog

- A picture of a cute animal (not mandatory but encouraged)

@mykolaf
Copy link

mykolaf commented Jul 1, 2020

Need to change the title. The issue is not with watermarkstat and CLI, the cause is that the BUFFER_POOL_WATERMARK is not enabled by default.

@stephenxs stephenxs changed the title [watermark] Fix error: watermarkstat -t buffer_pool doesn't work [watermark] Fix error: BUFFER_POOL_WATERMARK isn't enabled by default Jul 1, 2020
@stephenxs
Copy link
Owner Author

Need to change the title. The issue is not with watermarkstat and CLI, the cause is that the BUFFER_POOL_WATERMARK is not enabled by default.

Done.

Copy link

@mykolaf mykolaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stephenxs
Copy link
Owner Author

community PR 4882 opened

@stephenxs stephenxs closed this Jul 1, 2020
@stephenxs stephenxs deleted the fix-buffer-watermark-counter branch July 11, 2020 11:03
stephenxs pushed a commit that referenced this pull request Feb 10, 2022
457e94d51 [macsec_linux]: Fixbug cannot dump the PN due to type error (#42)
f7c073323 Disable P2P module (#41)
7b3b777e2 [ci]: use native arm64 and armhf build pool (#40)
d4e91d66c [sonic_operator]: Increase wait timeout (#39)
43611ef88e [sonic_operators]: Add log in sonic operators (#43)

Signed-off-by: Ze Gan <[email protected]>
stephenxs pushed a commit that referenced this pull request Mar 25, 2022
f00efef Longxiang Lyu Wed Mar 16 09:12:46 2022 +0800 Add a command line option to store logs into a separate file (#41)
ff2e67d Longxiang Lyu Tue Mar 15 09:10:59 2022 +0800 Add default port cable type (#39)
ebbb4d8 Jing Zhang Mon Mar 14 15:41:11 2022 -0700 Prevent switching MUX to "Unknown" (#36)
c779b8f Longxiang Lyu Thu Mar 10 21:35:11 2022 +0800 [nonfunctional] Use LinkProberStateMachineBase (#38)
b9fedd0 Longxiang Lyu Wed Mar 9 13:03:58 2022 +0800 [NONFUNCTIONAL] Add LinkProberStateMachineBase (#37)
bedd42b Longxiang Lyu Wed Mar 9 10:03:00 2022 +0800 Add .clang-format file to format code (#28)
9fe4fc6 Guohan Lu Thu Mar 3 17:51:43 2022 -0800 [doc]: add lgtm badge in README.md
c1249d9 Longxiang Lyu Wed Mar 2 18:05:18 2022 +0800 Enable lgtm (#33)
b8514c6 Longxiang Lyu Wed Mar 2 13:34:39 2022 +0800 Collect port cable type to use corresponding state machine (#31)
9b59ef9 Longxiang Lyu Wed Mar 2 07:19:33 2022 +0800 Improve make clean (#32)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants