-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split to a Grafana Service #180
Conversation
…akes a bit longer at my machine, so add some more timeout to prevent false negatives.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't had a chance to load it up on to a running Hubot, but the code looks great.
Will test it on a live Hubot today. Have a great new feature I want to add to our bot, so at the end of the day we'll know. |
…st coverage. The test template dashboard now has a parameterized title for the Graph panel (Graph for $server).
…ke `GrafanaDashboardResponse.Response`.
… custom responder.
Did some testing and some further refactoring. All my tests with a live Hubot were also OK. @stephenyeargin, we can merge if you don't see anything crazy. |
Looks good to me, I'll let you do the honors. I see you're sneaking it a bit of TypeScript. 😉 |
Hahaha. Yeah the d.ts files work great together with JS Docs. |
Partially fixes #177 in which we do a refactor to:
So in this PR we are doing the following:
Adapter
,GrafanaService
and theGrafanaClient
into aBot
class. This makes it a bit easier to interact with the package and not having to build your own class. I could not get the newBot
class to handle all the Hubot requests.--forbid-only --forbid-pending
when doing a commit or push, so we fail when we try to commit amocka.only
.GrafanaService
has all the business rules. One could use them without the bot (to collect multiple dashboards before sending them on).types.d.ts
so JSDoc understands what we're doing.