Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auth tokens should use a HMAC and not a simple hash based MAC #34

Open
DonnchaC opened this issue Feb 14, 2016 · 1 comment
Open

Auth tokens should use a HMAC and not a simple hash based MAC #34

DonnchaC opened this issue Feb 14, 2016 · 1 comment

Comments

@DonnchaC
Copy link

The auth tokens are vulnerable to a hash-extension attack as they don't use a real HMAC function. Simple hash based tokens containing a secret are not secure for authentication.

https://blog.skullsecurity.org/2012/everything-you-need-to-know-about-hash-length-extension-attacks
stesh pushed a commit that referenced this issue Feb 14, 2016
Use HMAC to generate auth tokens for cookies
d207801 
Addresses hash extension attack disclosed by @DonnchaC in #34
@stesh
Copy link
Owner

stesh commented Feb 14, 2016

Nice find. Candidate fix here: d207801

@stesh stesh mentioned this issue Feb 14, 2016
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stesh @DonnchaC