Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Spotless #1229

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use Spotless #1229

wants to merge 2 commits into from

Conversation

juherr
Copy link
Contributor

@juherr juherr commented Aug 30, 2023

No description provided.

@juherr
Copy link
Contributor Author

juherr commented Aug 30, 2023

@slachiewicz I used the Google format by default but I saw you contributed to palantir. I've never use it. Do you have any feedback to share?

@juherr
Copy link
Contributor Author

juherr commented Sep 11, 2023

Ping @goekay WDYT?

@slachiewicz Any advice between Google format and Palantir format?

@slachiewicz
Copy link
Contributor

We use the Spotless plugin to format Maven projects.
https://github.com/apache/maven-parent/blob/maven-parent-40/pom.xml#L1168-L1211

our configuration files can be found here: https://github.com/apache/maven-shared-resources/tree/master/src/main/resources/config

It works with sometimes minor issues like duplicate license headers for the first reformat, and issues with Java 21.
But in general, I would recommend using Spotless - we previously used only the checkstyle plugin and that was a nightmare to fix formatting errors.

@slachiewicz
Copy link
Contributor

and we disabled completely checkstyle plugin completely because with Spotless it is redundant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants