Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds mention of using RequestStore with Sidekiq #54

Merged
merged 1 commit into from
Jan 1, 2018
Merged

Adds mention of using RequestStore with Sidekiq #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ our controller:
def index
Thread.current[:counter] ||= 0
Thread.current[:counter] += 1

render :text => Thread.current[:counter]
end
```
Expand Down Expand Up @@ -97,6 +97,11 @@ def app
end
```

## Using with Sidekiq
This gem uses a Rack middleware to clear the store object after every request, but that doesn't translate well to background processing with [Sidekiq](https://github.com/mperham/sidekiq).

A companion library, [request_store-sidekiq](https://rubygems.org/gems/request_store-sidekiq) creates a Sidekiq middleware that will ensure the store is cleared after each job is processed, for security and consistency with how this is done in Rack.

## Semantic Versioning

This project conforms to [semver](http://semver.org/). As a result of this
Expand Down