Allow building NLOpt as permissive version without L-GPL licensed targets #569
+58
−20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jschueller
reviewed
Oct 4, 2024
jschueller
reviewed
Oct 4, 2024
jschueller
reviewed
Oct 7, 2024
markusgft
changed the title
jschueller
reviewed
Oct 7, 2024
jschueller
reviewed
Oct 7, 2024
jschueller
reviewed
Oct 7, 2024
jschueller
reviewed
Oct 7, 2024
jschueller
reviewed
Oct 7, 2024
jschueller
reviewed
Oct 7, 2024
jschueller
reviewed
Oct 7, 2024
jschueller
reviewed
Oct 8, 2024
jschueller
reviewed
Oct 8, 2024
jschueller
approved these changes
Oct 8, 2024
|
@jschueller thanks for your reviews. I believe I need your approval again before I can trigger a merge. Respectively, because I do not have write access, I believe that you need to trigger the merge. |
… licensed library.
markusgft
force-pushed
the
dev/notice_version
branch
from
5ddc1dd
to
f95d509
Compare
|
Friendly ping to @jschueller that I still need approval plus submit! Thanks. |
|
lets hear from @stevengj, he should have more infos about the license |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option to compile NLOpt without luksan solver. The resulting library will be fully permissively licensed. If luksan is included, NLOpt remains L-GPL.