Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move parts of DEBUG logging to TRACE #126

Closed
gitMiguel opened this issue Feb 6, 2022 · 3 comments
Closed

Move parts of DEBUG logging to TRACE #126

gitMiguel opened this issue Feb 6, 2022 · 3 comments

Comments

@gitMiguel
Copy link

While developing a modbus tool based on this library and switching loggin to debug I noticed these lines repeating quite often. IMO they should go to TRACE. Is there a reason why they are not? You think they could they be moved?

Example log

2022-02-06 09:37:00,516 [DEBUG] [.FastByteArrayInputStream] - reset()
2022-02-06 09:37:00,516 [DEBUG] [.FastByteArrayInputStream] - mark=0 pos=0
2022-02-06 09:37:00,516 [DEBUG] [.FastByteArrayInputStream] - mark()
2022-02-06 09:37:00,516 [DEBUG] [.FastByteArrayInputStream] - mark=0 pos=0
2022-02-06 09:37:00,516 [DEBUG] [.FastByteArrayInputStream] - read()
2022-02-06 09:37:00,516 [DEBUG] [.FastByteArrayInputStream] - count=10 pos=7
2022-02-06 09:37:00,516 [DEBUG] [.FastByteArrayInputStream] - reset()
2022-02-06 09:37:00,516 [DEBUG] [.FastByteArrayInputStream] - mark=0 pos=0
2022-02-06 09:37:00,516 [DEBUG] [.FastByteArrayInputStream] - read()
2022-02-06 09:37:00,516 [DEBUG] [.FastByteArrayInputStream] - count=10 pos=0
2022-02-06 09:37:00,517 [DEBUG] [.FastByteArrayInputStream] - read()
2022-02-06 09:37:00,517 [DEBUG] [.FastByteArrayInputStream] - count=10 pos=1
2022-02-06 09:37:00,517 [DEBUG] [.FastByteArrayInputStream] - read()
2022-02-06 09:37:00,517 [DEBUG] [.FastByteArrayInputStream] - count=10 pos=2
2022-02-06 09:37:00,517 [DEBUG] [.FastByteArrayInputStream] - read()
2022-02-06 09:37:00,517 [DEBUG] [.FastByteArrayInputStream] - count=10 pos=3
2022-02-06 09:37:00,517 [DEBUG] [.FastByteArrayInputStream] - read()
2022-02-06 09:37:00,517 [DEBUG] [.FastByteArrayInputStream] - count=10 pos=4
2022-02-06 09:37:00,517 [DEBUG] [.FastByteArrayInputStream] - read()
2022-02-06 09:37:00,517 [DEBUG] [.FastByteArrayInputStream] - count=10 pos=5
2022-02-06 09:37:00,517 [DEBUG] [.FastByteArrayInputStream] - read()
2022-02-06 09:37:00,517 [DEBUG] [.FastByteArrayInputStream] - count=10 pos=6
2022-02-06 09:37:00,517 [DEBUG] [.FastByteArrayInputStream] - read()
2022-02-06 09:37:00,517 [DEBUG] [.FastByteArrayInputStream] - count=10 pos=7
2022-02-06 09:37:00,517 [DEBUG] [.FastByteArrayInputStream] - read()
2022-02-06 09:37:00,517 [DEBUG] [.FastByteArrayInputStream] - count=10 pos=8
2022-02-06 09:37:00,517 [DEBUG] [.FastByteArrayInputStream] - read()
2022-02-06 09:37:00,517 [DEBUG] [.FastByteArrayInputStream] - count=10 pos=9

2022-02-06 09:37:00,517 [DEBUG] [mod.modbus.util.BitVector] - Get bit #0

@LivingWithHippos
Copy link

How did you set up the log level?

@gitMiguel
Copy link
Author

I'm developing with eclipse and use log4j. I have defined the logger like this:
<Logger name="com.ghgande.j2mod.modbus" level="debug"/>.

@steveohara
Copy link
Owner

Agreed - changed in next build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants