Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add user input validation on SerialParameters.java. #141

Merged
merged 1 commit into from
Oct 21, 2023
Merged

Add user input validation on SerialParameters.java. #141

merged 1 commit into from
Oct 21, 2023

Conversation

AmbroiseS
Copy link
Contributor

To avoid losing time on a typo like I did.
For example, invalid encoding silently defaults to ascii.

It will now throw an exception if the parameter is not recognised.

Probaly need to validate for other classes than Serial

@steveohara steveohara merged commit a608351 into steveohara:development Oct 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AmbroiseS @steveohara