Write tests for untested code. #104
Conversation
These changes were lost in a git checkout stash pop problem.
Classes no longer inherit from netbox_connect anymore. This caused issues with certain ,ethods needing access to the netbox api object and others not. To fix this the api object will be created once at the beginning of a user method and passed around each method thereafter. Also, fixed some type hinting mistakes.
These methods have been moved as they are to do with formatting dictionaries. It makes more sense to keep them in format_dict for now. Changed the test formatting to accommodate.
This test will need to test the netbox get id methods.
| Also, it allows dependency injection testing. | ||
| """ | ||
| self.enums_no_id = DeviceInfoNoID | ||
| self.netbox = netbox |
There was a problem hiding this comment.
Format dict shouldn't do anything which requires the netbox API....
There was a problem hiding this comment.
It doesn't do anything with Netbox. It just passes the api object through to the netbox_data.py . This allows you to initialise the api once at the start of a script and pass the api around from there, Rather than moving the url and tokens around and initialising a new api object for every method/class.
There was a problem hiding this comment.
We need to add a file called __init__.py to utils to resolve the import error, since this is a module but we're missing the module "marker file"
There was a problem hiding this comment.
utils does an __init__.py already in the directory.
This is to match the class name to the file name.
|
Pylint is going to fail on this branch due to the .pylintrc edit. I have already fixed these issues in another branch which I will merge once this branch merges. |
|
Sorry I sent you down the wrong track: The test file name (csv_to_dict.py) and the import needs fixing for this case, to match your rename to Once that's done I'm happy to pair program the pylint error, as suppressing it means it's not actually checking that file |
…' into write_tests_for_untested_code_v2
…' into write_tests_for_untested_code_v2
Cleaned up tests. Renamed files and refactored file structure. Moved some methods to more appropriate locations.