Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Created Argparse user method. #106

Merged
merged 26 commits into from
Oct 30, 2023
Merged

Created Argparse user method. #106

merged 26 commits into from
Oct 30, 2023

Commits on Oct 20, 2023

  1. initial argparse commit.

    @khalford
    khalford committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    5516f39 View commit details
    Browse the repository at this point in the history

  2. ENH: Constructed user method to create netbox devies from csv in CLI

    @khalford
    khalford committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    2adf199 View commit details
    Browse the repository at this point in the history

  3. BUG: Made changes for code to work. 

    The underlying code hasn't been tested in a while with a real netbox connection. These changes fix issues allowing devices to be created.
    @khalford
    khalford committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    d429668 View commit details
    Browse the repository at this point in the history

  4. Added a setup.py file to be able to pip install the package.

    @khalford
    khalford committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    4b2b052 View commit details
    Browse the repository at this point in the history

  5. MAINT: Ideal structure to contain the pynetbox logic

    @khalford
    khalford committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    908219c View commit details
    Browse the repository at this point in the history

  6. MAINT: Moved pynetbox logic into a class. 

    This keeps the code more organised and readable.
    @khalford
    khalford committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    bff7891 View commit details
    Browse the repository at this point in the history

  7. MAINT: Renamed Classes to init with api rather than netbox. 

    This is clearer when using imported methods because it shows api as an argument and not netbox.
    @khalford
    khalford committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    2966a25 View commit details
    Browse the repository at this point in the history

  8. MAINT: Created 2 functions to organise code. 

    Moved argparse logic into an independent function. Made a function to use the new class and do the methods.
    @khalford
    khalford committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    8e56485 View commit details
    Browse the repository at this point in the history

  9. MAINT: Black

    @khalford
    khalford committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    db57d5f View commit details
    Browse the repository at this point in the history

  10. MAINT: Pylint

    @khalford
    khalford committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    2fe1edf View commit details
    Browse the repository at this point in the history

  11. DOC: Docstrings.

    @khalford
    khalford committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    0ee8c49 View commit details
    Browse the repository at this point in the history

  12. MAINT: Added argparse to requirements.txt

    @khalford
    khalford committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    cb98a53 View commit details
    Browse the repository at this point in the history

  13. BUG: Added an ignore of setup.py to pytest.ini. 

    This makes sure pytest doesn't try to run setup.py as it does not need to be run or tested.
    @khalford
    khalford committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    34365ae View commit details
    Browse the repository at this point in the history

  14. MAINT: Pylint

    @khalford
    khalford committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    613138d View commit details
    Browse the repository at this point in the history

  15. MAINT: Moved file path param to method from __init__

    @khalford
    khalford committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    767d151 View commit details
    Browse the repository at this point in the history

  16. DOC: Edited .pylintrc 

    Now .pylintrc only contains necessary disabled warnings. Added docstrings.
    @khalford
    khalford committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    a952ddf View commit details
    Browse the repository at this point in the history

  17. Codecov YAML

    @khalford
    khalford committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    cb26919 View commit details
    Browse the repository at this point in the history

  18. BUG: Formatting dictionaries. 

    When formatting data in dictionaries. 2 enums files are used to provide the correct netbox attribute for a category of data. When choosing which enum to search the key value was not in uppercase like the enums values.
    @khalford
    khalford committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    7bfd284 View commit details
    Browse the repository at this point in the history

  19. MAINT: Code format and pretty prints 

    Changed classes to accept "api" parameter rather than netbox.
Also added some pretty print statements to describe what is happening when  the script is run.
    @khalford
    khalford committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    843de38 View commit details
    Browse the repository at this point in the history

  20. MAINT: Removed duplicate file from rebase.

    @khalford
    khalford committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    6de6fbf View commit details
    Browse the repository at this point in the history

  21. MAINT: Codecov running tests in project root not Pynetbox directory.

    @khalford
    khalford committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    6bebc8e View commit details
    Browse the repository at this point in the history

  22. MAINT: Running Codecov with the wrong args.

    @khalford
    khalford committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    867817d View commit details
    Browse the repository at this point in the history

  23. MAINT: Removed as unknown use.

    @khalford
    khalford committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    57be281 View commit details
    Browse the repository at this point in the history

  24. MAINT: Specified where the Codecov report is to upload.

    @khalford
    khalford committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    b0be9e6 View commit details
    Browse the repository at this point in the history

  25. BUG: Attempted fix to generate coverage report.

    @khalford
    khalford committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    f98b8c0 View commit details
    Browse the repository at this point in the history

  26. DOC: Missing parameters in Docstrings.

    @khalford
    khalford committed Oct 20, 2023
    Configuration menu
    Copy the full SHA
    3266780 View commit details
    Browse the repository at this point in the history