MAINT: refactor Openstack API openstack_identity #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove class - use functions instead. Now openstack_project we now take `conn` - openstack connection object for each function remove unnecessary functions
refactor tests for openstack_identity
RWhiting78
approved these changes
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting a feature branch to refactor openstack api and remove orquesta workflows. Since this is a feature branch - there will be a few failing tests whilst refactoring is underway.
Starting by rewriting Openstack Identity as functions instead of classes - makes it so much easier to read. Each function now takes a openstack connection object which is used to run openstacksdk commands.