Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: append_from props should be a list #261

Merged
merged 1 commit into from
Sep 27, 2024
Merged

BUG: append_from props should be a list #261

merged 1 commit into from
Sep 27, 2024

Conversation

gmatthews20
Copy link
Collaborator

Change props to the required type of List
Update tests

Description:

props param in append_from is a List, update email workflows and tests to match this

Special Notes:


Submitter:

Have you (where applicable):

  • Added unit tests?
  • Checked the latest commit runs on Dev?
  • Updated the example config file(s) and README?

Reviewer

Does this PR:

  • Place non-StackStorm code into the lib directory?
  • Have unit tests for the action/sensor and lib layers?
  • Have clear and obvious action parameter names and descriptions?

Change props to the required type of List
Update tests
Copy link

codecov bot commented Sep 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.20%. Comparing base (2468e98) to head (6c7a0f9).
Report is 61 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #261   +/-   ##
=======================================
  Coverage   98.20%   98.20%           
=======================================
  Files         195      195           
  Lines        7636     7636           
  Branches      460      460           
=======================================
  Hits         7499     7499           
  Misses        110      110           
  Partials       27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@meoflynn meoflynn merged commit fcc9395 into main Sep 27, 2024
14 checks passed
@meoflynn meoflynn deleted the george-dev branch September 27, 2024 09:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants