ENH: add search_by_expression workflow #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this workflow action allows querying generic openstack resources for numerical properties based on an expression - e.g "less-than" or "greater-than" a given threshold Future stackstorm actions will make use of it
anish-mudaraddi
force-pushed
the
add-search-by-expression
branch
from
375618f
to
a74bbcb
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #263 +/- ##
==========================================
- Coverage 98.20% 98.08% -0.13%
==========================================
Files 195 208 +13
Lines 7636 7989 +353
Branches 460 484 +24
==========================================
+ Hits 7499 7836 +337
- Misses 110 125 +15
- Partials 27 28 +1 ☔ View full report in Codecov by Sentry. |
lizsalmon
previously approved these changes
Oct 1, 2024
6 tasks
Neonbluestoplight
requested changes
Oct 2, 2024
Comment on lines
+10
to
+11
| @pytest.mark.parametrize( | ||
| "output_type", ["to_html", "to_string", "to_objects", "to_props"] |
There was a problem hiding this comment.
Just for understanding. This code allows testing of each of the types listed separately if I understand correctly?
There was a problem hiding this comment.
parametrize splits the test into 4 parts. Each test uses a different output_type parameter - set here to_html, to_string etc
There was a problem hiding this comment.
It's to save from writing each test separately - https://docs.pytest.org/en/7.1.x/example/parametrize.html
cloud.ymal -> cloud.yaml Co-authored-by: Nalin Gupta <[email protected]>
Neonbluestoplight
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this workflow action allows querying generic openstack resources for numerical properties based on an expression - e.g "less-than" or "greater-than" a given threshold
Future stackstorm actions will make use of it