ENH: add image search actions #277
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also added the action for searching images by using regex
Since the image ids would be unique, it would not be possible to group them. So removed it
- Fixed group by parameter to include null enum as default - Removed string properties to select from expression search action
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #277 +/- ##
=======================================
Coverage 98.15% 98.15%
=======================================
Files 230 230
Lines 8581 8581
Branches 518 518
=======================================
Hits 8423 8423
Misses 137 137
Partials 21 21 ☔ View full report in Codecov by Sentry. |
gmatthews20
requested changes
Oct 18, 2024
gmatthews20
requested changes
Oct 21, 2024
Comment on lines
+107
to
+116
| from_projects: | ||
| description: "(Optional) comma-spaced list of projects id/names to limit query to, if not provided, runs against all projects" | ||
| type: array | ||
| default: null | ||
| required: false | ||
| all_projects: | ||
| type: boolean | ||
| description: "tick to search in all projects - default True" | ||
| required: true | ||
| default: true |
There was a problem hiding this comment.
@anish-mudaraddi Is all_projects needed if when from_projects is not provided it runs against all projects?
There was a problem hiding this comment.
On this if from_projects and all_projects are false the it will default to searching the admin project
Might be worth changing the from_projects description to something along the lines of: (Optional) comma-spaced list of projects id/names to limit query to, if not provided, runs against all projects when all_projects is true
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
written by @Neonbluestoplight
Description:
Special Notes:
Submitter:
Have you (where applicable):
Reviewer
Does this PR:
libdirectory?liblayers?