Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Fix server actions #278

Merged
merged 1 commit into from
Oct 31, 2024
Merged

BUG: Fix server actions #278

merged 1 commit into from
Oct 31, 2024

Conversation

gmatthews20
Copy link
Collaborator

Remove extra line and duplicate keys from group_by enum in server actions

Description:

Special Notes:


Submitter:

Have you (where applicable):

  • Added unit tests?
  • Checked the latest commit runs on Dev?
  • Updated the example config file(s) and README?

Reviewer

Does this PR:

  • Place non-StackStorm code into the lib directory?
  • Have unit tests for the action/sensor and lib layers?
  • Have clear and obvious action parameter names and descriptions?

Remove extra line and duplicate keys from group_by enum in server actions
Copy link
Collaborator

@DavidFair DavidFair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot - might be worth adding some yaml linter for this repo to detect problems like this

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.03%. Comparing base (7548372) to head (d6853a1).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #278      +/-   ##
==========================================
- Coverage   98.12%   98.03%   -0.10%     
==========================================
  Files         223      230       +7     
  Lines        8408     8581     +173     
  Branches      511      518       +7     
==========================================
+ Hits         8250     8412     +162     
- Misses        137      141       +4     
- Partials       21       28       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@RJaliliSTFC RJaliliSTFC merged commit daf08d6 into main Oct 31, 2024
13 of 14 checks passed
@RJaliliSTFC RJaliliSTFC deleted the fix-server-actions branch October 31, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants