Add user query #89
Merged
Add user query #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And correct formatting
Methods moved as they can be used to query different resources Updates to the unit tests where needed
meoflynn
force-pushed
the
openstack-query/user-queries
branch
from
cb09196
to
cb7d614
Compare
Correct unit test for query manager Add method of parse subset and unit test for user_runner Fixes done based on errors raised by unit tests for user query
meoflynn
force-pushed
the
openstack-query/user-queries
branch
from
cb7d614
to
10993dc
Compare
meoflynn
force-pushed
the
openstack-query/user-queries
branch
3 times, most recently
from
0fca5f8
to
b4d463c
Compare
meoflynn
force-pushed
the
openstack-query/user-queries
branch
from
b4d463c
to
1204d93
Compare
fixed some failing tests also fixed some filepaths which were causing errors
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
==========================================
- Coverage 94.43% 94.40% -0.04%
==========================================
Files 89 95 +6
Lines 2248 2342 +94
Branches 222 232 +10
==========================================
+ Hits 2123 2211 +88
- Misses 111 114 +3
- Partials 14 17 +3
☔ View full report in Codecov by Sentry. |
add test cases for if either ouput_type or properties_to_select are not given
user-id is an invalid property
|
The StackStorm Actions we added |
anish-mudaraddi
approved these changes
Aug 3, 2023
There was a problem hiding this comment.
me and @meoflynn pair programmed this together and we're both happy with this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Special Notes:
Submitter:
Have you (where applicable):
Reviewer
Does this PR:
libdirectory?liblayers?