Skip to content
This repository has been archived by the owner on Jul 3, 2023. It is now read-only.

Adds Nullable validator #176

Merged
merged 2 commits into from
Aug 15, 2022
Merged

Adds Nullable validator #176

merged 2 commits into from
Aug 15, 2022

Conversation

elijahbenizzy
Copy link
Collaborator

@elijahbenizzy elijahbenizzy commented Aug 10, 2022 •
edited
Loading

A few minor usabiility issues when I was messing with some Stitch Fix code.

Changes

See commits.

Testing

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code can be automatically merged (no conflicts)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Passes all existing automated tests
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.
  • Reviewers requested with the Reviewers tool ➡️

Testing checklist

Python - local testing

  • python 3.6
  • python 3.7

@elijahbenizzy
Copy link
Collaborator Author

This is very simple, happy to change names

skrawcz
skrawcz suggested changes Aug 15, 2022
View reviewed changes
hamilton/data_quality/default_validators.py Outdated Show resolved Hide resolved
hamilton/graph.py Outdated Show resolved Hide resolved
skrawcz
skrawcz approved these changes Aug 15, 2022
View reviewed changes
Copy link
Collaborator

@skrawcz skrawcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you going to squash merge with a nice commit?

@elijahbenizzy
Copy link
Collaborator Author

elijahbenizzy commented Aug 15, 2022 •
edited
Loading

you going to squash merge with a nice commit?

Nope I'll turn this into two commits then commit them both -- should have been two PRs

@elijahbenizzy elijahbenizzy merged commit be2ba44 into main Aug 15, 2022
@elijahbenizzy elijahbenizzy deleted the nullable-validator branch August 15, 2022 16:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@skrawcz skrawcz skrawcz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elijahbenizzy @skrawcz