This repository has been archived by the owner on Jul 3, 2023. It is now read-only.
Fixes for @does #187
Merged
Fixes for @does #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elijahbenizzy
force-pushed
the
fix-does-bug
branch
13 times, most recently
from
09d52bd
to
b9d3663
Compare
|
Ughh this took longer than I want but I want to add the ability to have it work with |
elijahbenizzy
changed the title
elijahbenizzy
force-pushed
the
fix-does-bug
branch
from
b9d3663
to
e3cf805
Compare
|
@elijahbenizzy guess we need to fix the ray workflow API... seems like it changed. |
skrawcz
reviewed
Aug 26, 2022
hamilton/function_modifiers.py
Outdated
| @@ -85,8 +85,8 @@ def source(dependency_on: Any) -> UpstreamDependency: | |||
| This means that it comes from a node somewhere else. | |||
| E.G. source("foo") means that it should be assigned the value that "foo" outputs. | |||
|
|
|||
| @param dependency_on: Upstream node to come from | |||
| @return:An UpstreamDependency object -- a signifier to the internal framework of the dependency type. | |||
| :paramdependency_on: Upstream node to come from | |||
skrawcz
suggested changes
Aug 27, 2022
elijahbenizzy
force-pushed
the
fix-does-bug
branch
from
e3cf805
to
7e51f84
Compare
This enables more complex polymorphically applicable functions without the pain of implementing sophisticated type-checking. Furthermore, I think this was overreach by the Hamilton framework. Hamilton cares about relationships between nodes, and not the implementation of nodes. As `@does` creates a node, this does not impact the relationship between nodes, meaning that this type of type-checking is out of scope.
elijahbenizzy
force-pushed
the
fix-does-bug
branch
from
21b4b80
to
6c686ea
Compare
skrawcz
approved these changes
Aug 30, 2022
Co-authored-by: Stefan Krawczyk <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to add a few more pieces to make this work -- this is a WIP.
[Short description explaining the high-level reason for the pull request]
Changes
Testing
Notes
Checklist
Testing checklist
Python - local testing