This repository has been archived by the owner on Jul 3, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 37
Fixes ray workflow adapter to work with Ray 2.0 #189
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elijahbenizzy
force-pushed
the
ray-fixes
branch
3 times, most recently
from
August 28, 2022 23:51
40ed6ba
to
479da70
Compare
Local error: # TODO(ujvl): Consider how to allow user to retrieve the ready objects.
values, debugger_breakpoint = worker.get_objects(object_refs, timeout=timeout)
for i, value in enumerate(values):
if isinstance(value, RayError):
if isinstance(value, ray.exceptions.ObjectLostError):
worker.core_worker.dump_object_store_memory_usage()
if isinstance(value, RayTaskError):
> raise value.as_instanceof_cause()
E ray.exceptions.RayTaskError(WorkflowExecutionError): ray::WorkflowManagementActor.execute_workflow() (pid=90345, ip=127.0.0.1, repr=<ray.workflow.workflow_access.WorkflowManagementActor object at 0x11bf64670>)
E ray.exceptions.RayTaskError(RecursionError): ray::_workflow_task_executor_remote() (pid=90344, ip=127.0.0.1)
E File "/Users/elijahbenizzy/.pyenv/versions/hamilton-fresh/lib/python3.9/site-packages/ray/workflow/task_executor.py", line 115, in _workflow_task_executor_remote
E return _workflow_task_executor(
E File "/Users/elijahbenizzy/.pyenv/versions/hamilton-fresh/lib/python3.9/site-packages/ray/workflow/task_executor.py", line 84, in _workflow_task_executor
E raise e
E File "/Users/elijahbenizzy/.pyenv/versions/hamilton-fresh/lib/python3.9/site-packages/ray/workflow/task_executor.py", line 79, in _workflow_task_executor
E output = func(*args, **kwargs)
E File "/Users/elijahbenizzy/dev/dagworks/hamilton/hamilton/experimental/h_ray.py", line 151, in <lambda>
E def check_node_type_equivalence(node_type: typing.Type, input_type: typing.Type) -> bool:
E File "/Users/elijahbenizzy/dev/dagworks/hamilton/hamilton/experimental/h_ray.py", line 151, in <lambda>
E def check_node_type_equivalence(node_type: typing.Type, input_type: typing.Type) -> bool:
E File "/Users/elijahbenizzy/dev/dagworks/hamilton/hamilton/experimental/h_ray.py", line 151, in <lambda>
E def check_node_type_equivalence(node_type: typing.Type, input_type: typing.Type) -> bool:
E [Previous line repeated 991 more times]
E RecursionError: maximum recursion depth exceeded
E
E The above exception was the direct cause of the following exception:
E
E ray::WorkflowManagementActor.execute_workflow() (pid=90345, ip=127.0.0.1, repr=<ray.workflow.workflow_access.WorkflowManagementActor object at 0x11bf64670>)
E File "/Users/elijahbenizzy/.pyenv/versions/3.9.10/lib/python3.9/concurrent/futures/_base.py", line 439, in result
E return self.__get_result()
E File "/Users/elijahbenizzy/.pyenv/versions/3.9.10/lib/python3.9/concurrent/futures/_base.py", line 391, in __get_result
E raise self._exception
E File "/Users/elijahbenizzy/.pyenv/versions/hamilton-fresh/lib/python3.9/site-packages/ray/workflow/workflow_access.py", line 209, in execute_workflow
E await executor.run_until_complete(job_id, context, wf_store)
E File "/Users/elijahbenizzy/.pyenv/versions/hamilton-fresh/lib/python3.9/site-packages/ray/workflow/workflow_executor.py", line 109, in run_until_complete
E await asyncio.gather(
E File "/Users/elijahbenizzy/.pyenv/versions/hamilton-fresh/lib/python3.9/site-packages/ray/workflow/workflow_executor.py", line 356, in _handle_ready_task
E raise err
E ray.workflow.exceptions.WorkflowExecutionError: Workflow[id=test-test_smoke_screen_module] failed during execution. |
elijahbenizzy
changed the title
Fixes ray integration tests WIP
Fixes ray integration tests
Aug 29, 2022
elijahbenizzy
changed the title
Fixes ray integration tests
Fixes ray workflow adapter to work with Ray 2.0
Aug 29, 2022
skrawcz
suggested changes
Aug 29, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you put more info into the commit message please? e.g. ray 2.0 came out and since ray workflows are in alpha the API broke, and now they use bind
...
12 tasks
elijahbenizzy
force-pushed
the
ray-fixes
branch
from
August 29, 2022 03:58
479da70
to
374922a
Compare
Ray workflows was in an experimental state. With the release of Ray 2.0.0 the workflow API changed. This adapts to work with the new API.
elijahbenizzy
force-pushed
the
ray-fixes
branch
from
August 29, 2022 04:01
395d878
to
b8f9d2b
Compare
skrawcz
approved these changes
Aug 29, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New ray workflows API integration. This breaks when running locally (for me) with a very cryptic RecursionError. Spent some time digging in and I think its something odd with my env?
Changes
Testing
Notes
Checklist
Testing checklist
Python - local testing