This repository has been archived by the owner on Jul 3, 2023. It is now read-only.
Fixes does function wrapping #244 #245
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In issue #244 types were not being propagated of the function being wrapped. This changes that by adding the functools.wraps decorator. Adds a unit test to test for two decorators playing nice together and verified that it's broken before and fixed afterwards.
elijahbenizzy
approved these changes
Dec 14, 2022
| @@ -754,7 +755,7 @@ def replacing_function(__fn=fn, **kwargs): | |||
| final_kwarg_values = does.map_kwargs(final_kwarg_values, self.argument_mapping) | |||
| return self.replacing_function(**final_kwarg_values) | |||
|
|
|||
| return node.Node.from_fn(fn).copy_with(callabl=replacing_function) | |||
| return node.Node.from_fn(fn).copy_with(callabl=wrapper_function) | |||
There was a problem hiding this comment.
OK, so let's ship this as it fixes it. I'm confused as to how this didn't take the original function:
Line 201 in 37317b1
There was a problem hiding this comment.
No no, that's not the fix.
- I found it confusing that the callable created was named the same as the internal function -- hence this change.
- The actual fix is the
functools.wrapsand removing__fnparameter.
|
Closing in favor of #247 . |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In issue #244 types were not being propagated of the function being wrapped.
This changes that by adding the functools.wraps decorator.
Adds a unit test to test for two decorators playing nice together and verified that it's broken before and fixed afterwards.
Changes
@doeswrapper function to properly emulate the signature of the function it is replacing.How I tested this
Notes
Checklist