Skip to content
This repository has been archived by the owner on Jul 3, 2023. It is now read-only.

Python 3 11 support #291

Merged
merged 3 commits into from
Jan 30, 2023
Merged

Python 3 11 support #291

merged 3 commits into from
Jan 30, 2023

Conversation

elijahbenizzy
Copy link
Collaborator

[Short description explaining the high-level reason for the pull request]

Changes

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

@elijahbenizzy
Copy link
Collaborator Author

Removed tests, decided not to make it impossible to install as I don't want to create a new major version. Next major version release will probably be. 3.8 or 3.10 +.

@elijahbenizzy elijahbenizzy marked this pull request as ready for review January 29, 2023 21:13
Copy link
Collaborator

@skrawcz skrawcz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see how this fulfills requirements for 3.11 and removing 3.6

  1. can the 3.6 commit be separate please?
  2. I think there's a few changes that are missing:
  • setup.py is not modified.
  • requirements.txt isn't updated
  • references to 3.6 python aren't removed -- line 79 in hamilton/base.py, line 91 in test_h_async.py

.circleci/config.yml Show resolved Hide resolved
@elijahbenizzy
Copy link
Collaborator Author

I don't see how this fulfills requirements for 3.11 and removing 3.6

  1. can the 3.6 commit be separate please?
  2. I think there's a few changes that are missing:
  • setup.py is not modified.
  • requirements.txt isn't updated
  • references to 3.6 python aren't removed -- line 79 in hamilton/base.py, line 91 in test_h_async.py

Can split out commits. See #291 (comment) for why I didn't fully remove 3.6 support. I think we'd have to cut a major version or break the semantic versioning rules. I guess we could cut a minor one...

@elijahbenizzy elijahbenizzy force-pushed the python-3-11-support branch 4 times, most recently from 59c631f to 8ae243c Compare January 30, 2023 02:28
@elijahbenizzy
Copy link
Collaborator Author

Think I got everything

@skrawcz
Copy link
Collaborator

skrawcz commented Jan 30, 2023

I don't see how this fulfills requirements for 3.11 and removing 3.6

  1. can the 3.6 commit be separate please?
  2. I think there's a few changes that are missing:
  • setup.py is not modified.
  • requirements.txt isn't updated
  • references to 3.6 python aren't removed -- line 79 in hamilton/base.py, line 91 in test_h_async.py

Can split out commits. See #291 (comment) for why I didn't fully remove 3.6 support. I think we'd have to cut a major version or break the semantic versioning rules. I guess we could cut a minor one...

As discussed. I think we're fine. Python 3.6 people just wont get new updates -- so no broken functionality for them.

@skrawcz
Copy link
Collaborator

skrawcz commented Jan 30, 2023

@elijahbenizzy just requirements.txt -- doesn't need dataclasses conditional install anymore

@elijahbenizzy elijahbenizzy merged commit 7f53f88 into main Jan 30, 2023
@elijahbenizzy elijahbenizzy deleted the python-3-11-support branch January 30, 2023 17:11
This was linked to issues Jan 31, 2023
@skrawcz skrawcz mentioned this pull request Jan 31, 2023
6 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove 3.6 Support Python 3.11 support
2 participants