-
Notifications
You must be signed in to change notification settings - Fork 37
Conversation
f5365f0
to
2085674
Compare
8f5b117
to
2085674
Compare
Removed tests, decided not to make it impossible to install as I don't want to create a new major version. Next major version release will probably be. 3.8 or 3.10 +. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see how this fulfills requirements for 3.11 and removing 3.6
- can the 3.6 commit be separate please?
- I think there's a few changes that are missing:
- setup.py is not modified.
- requirements.txt isn't updated
- references to 3.6 python aren't removed -- line 79 in hamilton/base.py, line 91 in test_h_async.py
Can split out commits. See #291 (comment) for why I didn't fully remove 3.6 support. I think we'd have to cut a major version or break the semantic versioning rules. I guess we could cut a minor one... |
59c631f
to
8ae243c
Compare
8ae243c
to
87d647d
Compare
Think I got everything |
87d647d
to
a9d4933
Compare
As discussed. I think we're fine. Python 3.6 people just wont get new updates -- so no broken functionality for them. |
@elijahbenizzy just requirements.txt -- doesn't need dataclasses conditional install anymore |
a9d4933
to
04afe86
Compare
[Short description explaining the high-level reason for the pull request]
Changes
How I tested this
Notes
Checklist