False positives in JSONObject.similar() and JSONArray.similar()?

[enoes]

I'm afraid the for-loops in the above mentioned methods are breaking to soon if only one similarity was detected, see line 1487 in JSONObject.java and 1292 in JSONArray.java. Or did I overlook something?

[johnjaylward]

Yes, you did. Those lines are determining if the 2 references in memory are the same. If they are, there is no way their child objects could differ.

• https://github.com/stleary/JSON-java/blob/master/JSONObject.java#L1847
• https://github.com/stleary/JSON-java/blob/master/JSONArray.java#L1292

[johnjaylward]

wait, you may be correct. @stleary , let me make a test case just to confirm. it's possible that those returns should be continuess instead

[stleary]

Issue resolved.