Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this code solve?
java.io.Writer
to use ajava.lang.Appendable
instead. Situations whereAppendable
can be used where
Writer
cannot include theStringBuffer
,StringBuilder
, andCharBuffer
classes.Risks
Low risk. This is modifying an API method to take an interface instead of a base class, which is generally a good practice. The positive unit test coverage is good. But JSONWriter is lacking coverage for most of the thrown exceptions, including in modified methods. OK to commit, but better unit test code coverage will be required before this code can be included in a release. See stleary/JSON-Java-unit-test#56.
Changes to the API?
The constructor for JSONWriter has changed from
Writer
toAppendable
.Will this require a new release?
Can be rolled into the next release, pending completion of the unit tests.
Should the documentation be updated?
Not required.
Does it break the unit tests?
No, the current tests run successfully. However, new unit tests have been added. See
stleary/JSON-Java-unit-test#53