Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provides "#" string evaluation support for JSON Pointer #292

Merged
merged 1 commit into from
Oct 8, 2016

Conversation

erosb
Copy link
Contributor

@erosb erosb commented Oct 5, 2016

No description provided.

@stleary
Copy link
Owner

stleary commented Oct 6, 2016

What problem does this code solve?
In the JSON Pointer spec, "#" and "" are equivalent strings

Risks
Low. This adds required functionality to an ancillary JSON-Java feature. While existing apps may erroneously depend on the existing behavior, this is still a relatively new feature.

Changes to the API?
No.

Will this require a new release?
May be rolled into the next release.

Should the documentation be updated?
No.

Does it break the unit tests?
No, but a new unit test is added to exercise this code change.

Review status
ACCEPT. Starting 3 day comment window with this post.

@stleary stleary changed the title fixing #291 Provides "#" pointer string evaluation support for JSON Pointer Oct 6, 2016
@stleary stleary changed the title Provides "#" pointer string evaluation support for JSON Pointer Provides "#" string evaluation support for JSON Pointer Oct 6, 2016
@stleary stleary merged commit 237376e into stleary:master Oct 8, 2016
stleary added a commit to stleary/JSON-Java-unit-test that referenced this pull request Oct 8, 2016
erosb added a commit to everit-org/json-schema that referenced this pull request May 18, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants