-
Notifications
You must be signed in to change notification settings - Fork 177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remap enums #462
Open
burrbull
wants to merge
10
commits into
master
Choose a base branch
from
maps
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
remap enums #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
burrbull
force-pushed
the
maps
branch
3 times, most recently
from
April 12, 2023 14:09
01cec99
to
27d0358
Compare
burrbull
force-pushed
the
maps
branch
2 times, most recently
from
July 29, 2023 04:06
8fc3883
to
799ac57
Compare
therealprof
approved these changes
Jul 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, not in a position to test this ATM, though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is breaking change.
It uses similar idea to stm32-rs/stm32f4xx-hal#594 and family, but different.
Istead of
pins: TupleOfPinEnums
peripheral keepspins: EnumOfPinTupleCombinations
. It is less beautiful and flexible, but gives workaround forAFIO
map issues (which is F1 only).Needs complex testing. cc @all_who_can_test_and_have_ideas :)