Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap QSPI pins #283

Merged
merged 1 commit into from
Jan 9, 2022
Merged

Swap QSPI pins #283

merged 1 commit into from
Jan 9, 2022

Conversation

DerFetzer
Copy link
Contributor

As strange as it seems PB0 and PB1 are the other way round for QSPI (tested on STM32L496).

image

@korken89
Copy link
Collaborator

korken89 commented Jan 9, 2022

Thanks for fixing!
There seems to be some collisions happening, can you look into fixing the CI issues?

@DerFetzer
Copy link
Contributor Author

There were manual trait implementations for some variants.
I checked their datasheets and they use PB0 as IO1 and PB1 as IO0 as well so I removed the conflicting one and the one for PB2 was clearly wrong.

@korken89 korken89 merged commit fcd8969 into stm32-rs:master Jan 9, 2022
Crzyrndm pushed a commit to Crzyrndm/stm32l4xx-hal that referenced this pull request Feb 9, 2022
@DerFetzer @Crzyrndm
Swap QSPI pins and remove conflicting/wrong implementations (stm32-rs…
9cb7e98 
…#283)

# Conflicts:
#	src/qspi.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@korken89 korken89 korken89 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DerFetzer @korken89