Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/remove http header cookie #194

Merged
merged 3 commits into from
Aug 15, 2022
Merged

Bugfix/remove http header cookie #194

merged 3 commits into from
Aug 15, 2022

Conversation

Sn0rt
Copy link
Contributor

@Sn0rt Sn0rt commented Aug 15, 2022 •
edited
Loading

  1. remove cookie ( the header can set by manually bugfix: unexpected http header with Cookie #191
  2. bugfix: only set etag which query from /bios/setting

stmcginnis
stmcginnis approved these changes Aug 15, 2022
View reviewed changes
Copy link
Owner

@stmcginnis stmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Wasn't sure about dropping the cookie, but noticed this explicit statement in the redfish spec:

Shall not use HTTP cookies to authenticate any activity, such as GET , POST , PUT , PATCH , and DELETE .

@stmcginnis stmcginnis merged commit 83d861c into stmcginnis:main Aug 15, 2022
@stmcginnis stmcginnis mentioned this pull request Aug 15, 2022
Closed
@Sn0rt
Copy link
Contributor Author

Sn0rt commented Aug 16, 2022

Looks good. Wasn't sure about dropping the cookie, but noticed this explicit statement in the redfish spec:

Shall not use HTTP cookies to authenticate any activity, such as GET , POST , PUT , PATCH , and DELETE .

the user can add this header manually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stmcginnis stmcginnis stmcginnis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Sn0rt @stmcginnis