Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Manual Sync] Prevent panic when using the managed-cluster-configfile argument #222

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

zyjjay
Copy link

@zyjjay zyjjay commented Dec 4, 2023

Some previous change seems to have removed the case to parse the congif when the managed-cluster-configfile argument is specified.

Signed-off-by: mprahl [email protected]
(cherry picked from commit 08dd229)
closes: #220

Some previous change seems to have removed the case to parse the congif
when the managed-cluster-configfile argument is specified.

Signed-off-by: mprahl <[email protected]>
(cherry picked from commit 08dd229)
Copy link

openshift-ci bot commented Dec 4, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mprahl, zyjjay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved label Dec 4, 2023
@zyjjay zyjjay changed the title Prevent panic when using the managed-cluster-configfile argument [Manual Sync] Prevent panic when using the managed-cluster-configfile argument Dec 4, 2023
Copy link

sonarcloud bot commented Dec 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

80.0% 80.0% Coverage
0.0% 0.0% Duplication

@openshift-merge-bot openshift-merge-bot bot merged commit b01ad04 into main Dec 4, 2023
15 checks passed
@openshift-merge-bot openshift-merge-bot bot deleted the fix-panic branch December 4, 2023 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

😿 Failed to sync the upstream PRs: #99, #100, #101
2 participants