Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add MulticastScrollViewDelegate #19

Merged
merged 3 commits into from
Oct 11, 2024
Merged

Add MulticastScrollViewDelegate #19

merged 3 commits into from
Oct 11, 2024

Conversation

julasamer
Copy link

@julasamer julasamer commented Oct 10, 2024 •
edited by stonko1994
Loading

  • existing UIScrollView delegates are no longer overwritten
  • allows registration of multiple handlers on the same scroll view

Fixes #1

Add MulticastScrollViewDelegate
f7e9ef2 
- existing UIScrollView delegates are no longer overwritten
- allows registration of multiple handlers on the same scroll view
stonko1994
stonko1994 requested changes Oct 10, 2024
View reviewed changes
Copy link
Owner

@stonko1994 stonko1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your contribution. Change look good in general.

Please address the SwiftLint warnings and consider my comments.

Sources/SimultaneouslyScrollView/Extensions/MulticastScrollViewDelegate.swift Outdated Show resolved Hide resolved
Sources/SimultaneouslyScrollView/Extensions/MulticastScrollViewDelegate.swift Outdated Show resolved Hide resolved
Sources/SimultaneouslyScrollView/Extensions/MulticastScrollViewDelegate.swift Outdated Show resolved Hide resolved
Sources/SimultaneouslyScrollView/Extensions/MulticastScrollViewDelegate.swift Outdated Show resolved Hide resolved
Sources/SimultaneouslyScrollView/Helper/ScrollViewDecorator.swift Outdated Show resolved Hide resolved
Sources/SimultaneouslyScrollView/Extensions/MulticastScrollViewDelegate.swift Outdated Show resolved Hide resolved
Sources/SimultaneouslyScrollView/Extensions/MulticastScrollViewDelegate.swift Outdated Show resolved Hide resolved
@stonko1994 stonko1994 self-requested a review October 11, 2024 20:23
@stonko1994 stonko1994 merged commit 4c0936d into stonko1994:main Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stonko1994 stonko1994 stonko1994 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Delegate is overridden on register(scrollView:)
2 participants
@julasamer @stonko1994