Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: preserveKeyOrder option #36

Merged
merged 6 commits into from
Dec 4, 2019
Merged

feat: preserveKeyOrder option #36

merged 6 commits into from
Dec 4, 2019

Conversation

P0lip
Copy link
Contributor

@P0lip P0lip commented Nov 28, 2019 •
edited
Loading

Will help with stoplightio/spectral#730

Some extra context can be found in the sibling PR for YAML Package. stoplightio/yaml#32

@P0lip P0lip added the enhancement New feature or request label Nov 28, 2019
@P0lip P0lip requested a review from marbemac November 28, 2019 22:50
@P0lip P0lip self-assigned this Nov 28, 2019
@P0lip
Copy link
Contributor Author

P0lip commented Dec 4, 2019

Suggest reviewing #37 first

@P0lip P0lip changed the title feat: sortKeys option feat: preserveKeyOrder option Dec 4, 2019
billiegoose
billiegoose approved these changes Dec 4, 2019
View reviewed changes
Copy link
Contributor

@billiegoose billiegoose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no labels, looks good

@P0lip P0lip merged commit 1fc6328 into master Dec 4, 2019
@P0lip P0lip deleted the feat/sort-keys branch December 4, 2019 16:03
@stoplight-bot
Copy link
Collaborator

🎉 This PR is included in version 3.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@billiegoose billiegoose billiegoose approved these changes

@marbemac marbemac Awaiting requested review from marbemac

Assignees

@P0lip P0lip

Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@P0lip @stoplight-bot @billiegoose