Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weekly fixes for Prism #1107

Merged
merged 7 commits into from
Apr 27, 2020
Merged

Weekly fixes for Prism #1107

merged 7 commits into from
Apr 27, 2020

Conversation

XVincentX
Copy link
Contributor

@XVincentX XVincentX commented Apr 25, 2020 •
edited
Loading

Closes #1106
Closes #1103
Closes #1104

@XVincentX XVincentX mentioned this pull request Apr 25, 2020
Closed
@XVincentX XVincentX marked this pull request as ready for review April 25, 2020 01:37
@XVincentX XVincentX requested a review from lottamus April 25, 2020 02:08
karol-maciaszek
karol-maciaszek suggested changes Apr 27, 2020
View reviewed changes
Copy link
Contributor

@karol-maciaszek karol-maciaszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Three birds with one stone, nice :]

packages/cli/src/util/createServer.ts Outdated Show resolved Hide resolved
packages/http/src/getHttpOperations.ts Show resolved Hide resolved
@XVincentX XVincentX merged commit 3401aa3 into master Apr 27, 2020
@XVincentX XVincentX deleted the various-fixes branch April 27, 2020 16:08
@sgrmgj
Copy link

sgrmgj commented Apr 28, 2020

@XVincentX I am still not able to execute this as per the documentation -
docker run --init --rm -it -v "$(pwd):/tmp" -P stoplight/prism:3 mock -h 0.0.0.0 /tmp/openapi.v1.json
[11:50:23 AM] › [CLI] … awaiting Starting Prism…

It just breaks, still not able to use the prism image

@XVincentX
Copy link
Contributor Author

XVincentX commented Apr 28, 2020 •
edited by marcelltoth
Loading

@sgrmgj-quotient We have not released yet a new Prism version. You would need to build the docker image by yourself first:

  1. Clone the source code
  2. docker build -t prism .

@sgrmgj
Copy link

sgrmgj commented Apr 28, 2020 •
edited
Loading

okay cool I will do that thanks @XVincentX
Again really appreciate all the help. Thank you so much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karol-maciaszek karol-maciaszek karol-maciaszek requested changes

@marcelltoth marcelltoth Awaiting requested review from marcelltoth

@lottamus lottamus Awaiting requested review from lottamus

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@XVincentX @sgrmgj @karol-maciaszek