chore: PR feedback

stoplightio · Dec 20, 2019 · 334bf49 · 334bf49
1 parent 3f2c731
commit 334bf49
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 7 deletions.
diff --git a/src/spectral.ts b/src/spectral.ts
@@ -100,7 +100,7 @@ export class Spectral {
       this._parsedRefs,
     );
 
-    let validationResults = [...refDiagnostics, ...results, ...formatResolverErrors(resolved)];
+    const validationResults = [...refDiagnostics, ...results, ...formatResolverErrors(resolved)];
 
     if (resolved.formats === void 0) {
       const registeredFormats = Object.keys(this.formats);
@@ -115,11 +115,12 @@ export class Spectral {
       }
     }
 
-    validationResults = validationResults.concat(runRules(resolved, this.rules, this.functions));
-
     return {
       resolved: resolved.resolved,
-      results: prepareResults(validationResults, this._computeFingerprint),
+      results: prepareResults(
+        [...validationResults, ...runRules(resolved, this.rules, this.functions)],
+        this._computeFingerprint,
+      ),
     };
   }
 

diff --git a/src/utils/prepareResults.ts b/src/utils/prepareResults.ts
@@ -30,9 +30,7 @@ export const prepareResults = (results: IRuleResult[], computeFingerprint: Compu
 const decorateResultsWithFingerprint = (results: IRuleResult[], computeFingerprint: ComputeFingerprintFunc) => {
   for (const r of results) {
     Object.defineProperty(r, 'fingerprint', {
-      get() {
-        return computeFingerprint(r, md5);
-      },
+      value: computeFingerprint(r, md5),
     });
   }