fix(rulesets): require node_module (#1029)

* fix(rulesets): require node_module

* test: remove node_modules dir

src/rulesets/evaluators.ts

@@ -47,6 +47,8 @@ function proxyRequire(source: string): NodeJS.Require {
   function req(p: string) {
     if (p.startsWith('.')) {
       p = join(source, '..', stripRoot(p));
+    } else {
+      p = require.resolve(p, { paths: [join(source, '..')] });
     }
 
     return actualRequire.call(null, p);

test-harness/index.ts

@@ -27,13 +27,18 @@ describe('cli acceptance tests', () => {
     beforeAll(async () => {
       await Promise.all(
         scenario.assets.map(async ([asset]) => {
-          const tmpFileHandle = await tmpFile();
+          const ext = path.extname(asset);
+          const tmpFileHandle = await tmpFile({
+            ...(ext && { postfix: ext }),
+          });
+
           tmpFileHandles.set(asset, tmpFileHandle);
 
           const normalizedName = normalize(tmpFileHandle.name);
 
           replacements[asset] = normalizedName;
           replacements[`${asset}|no-ext`] = normalizedName.replace(new RegExp(`${path.extname(normalizedName)}$`), '');
+          replacements[`${asset}|filename|no-ext`] = path.basename(normalizedName, true);
         }),
       );
 

test-harness/scenarios/require-module.scenario

@@ -0,0 +1,36 @@
+====test====
+Custom function is able to require a module
+====document====
+{}
+====asset:fn.js====
+const fs = require('fs');
+const path = require('path');
+const nodeModulesDir = path.join('{asset:fn.js}', '../node_modules');
+const packageDir = path.join(nodeModulesDir, 'foo');
+
+fs.mkdirSync(packageDir, { recursive: true });
+fs.writeFileSync(path.join(packageDir, 'package.json'), JSON.stringify({ main: './index.js' }));
+fs.writeFileSync(path.join(packageDir, 'index.js'), 'module.exports = Function()');
+
+try {
+  require('foo'); // this will throw if foo cannot be resolved
+} finally {
+  fs.unlinkSync(path.join(packageDir, 'package.json'));
+  fs.unlinkSync(path.join(packageDir, 'index.js'));
+  fs.rmdirSync(packageDir);
+  fs.rmdirSync(nodeModulesDir);
+}
+
+module.exports = () => void 0;
+====asset:ruleset====
+functions: ["{asset:fn.js|filename|no-ext}"]
+functionsDir: "."
+rules:
+  has-property:
+    given: $
+    then:
+      function: "{asset:fn.js|filename|no-ext}"
+====command====
+{bin} lint {document} --ruleset {asset:ruleset} --ignoreUnknownFormat
+====status====
+0