chore(ruleset): improve then validation #1144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nulltoken
previously approved these changes
May 6, 2020
nulltoken
reviewed
May 6, 2020
P0lip
force-pushed
the
fix/ruleset-function-validation
branch
from
c2a65ba
to
bd7bcf1
Compare
P0lip
force-pushed
the
fix/ruleset-function-validation
branch
from
bd7bcf1
to
96c8842
Compare
|
@nulltoken bump 🙂 |
|
Since there is only the doc change that hasn't been reviewed, I'll go ahead and merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a complementary PR to #1136
Checklist
Does this PR introduce a breaking change?
Additional context
Enhances the ruleset validation to make sure all known
thenwith a built-in function are validated according to the typings.The benefit of that change is the lack of need for any types clobbering as well as any other custom validation (like we had to do in case of casing fn, for instance)