test(asyncapi): use a simple rule tester #1650
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #1082 and #1618
Checklist
Does this PR introduce a breaking change?
Additional context
This essentially removes all the boilerplate and burden we needed to test a particular rule.
Right now, that logic is hidden in a single file, while each test is actually oriented on the expected output.
I'm planning to apply the same change to the OAS ruleset tests.
Later on, when built-in rulesets have new home, we'll either leave a util in Spectral (I bet this will be super useful for other rulesets too, in a similar fashion to the ESLint offers), or move the util altogether to the new repo.
I feel like it doesn't make sense to review each file - verifying the approach is what we should put more focus on.
Thea idea is that instead of initializing Spectral with a ruleset, and then writing assertions manually, etc., you simply rely on
testRule
to do all of that.This way we're totally independent of changes occurring to Spectral.