chore: typecheck the tests before build #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@P0lip will leave this up to you |
P0lip
reviewed
Oct 15, 2019
package.json
Outdated
| @@ -35,7 +35,7 @@ | |||
| "scripts": { | |||
| "build.binary": "pkg . --output ./binaries/spectral", | |||
| "build.oas-functions": "rollup -c", | |||
| "build": "tsc -p ./tsconfig.build.json", | |||
| "build": "tsc --noEmit && tsc -p ./tsconfig.build.json", | |||
There was a problem hiding this comment.
Could we move tsc --noEmit to lint?
There was a problem hiding this comment.
@P0lip 👍 Will update this.
P0lip
approved these changes
Oct 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Does this PR introduce a breaking change?
While working on #635, I had to add a property to
IFunctionValues.yarn buildhelped me find where I had to fix the code.yarn lintwas all good.As the full test suite usually takes a long time to run on my box, I tend to only run the tests that impact the code I'm working on. And let the CI server deal with the rest.
Of course, I discovered that I had forgotten to also fix some tests by taking a look a the failed karma tests on the CI server.
This PR aims at reducing the feedback loop (a little) by also typechecking the tests (without emitting code) before the build per se. By doing so, It adds a little overhead to the build time and an additional moving piece to the pipeline.
What do you think?