chore: Bump @stoplight/json-ref-resolver from 2.2.0 to 2.3.0 #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@P0lip Could you please take a look a this when you've got some spare time? |
P0lip
reviewed
Oct 10, 2019
src/__tests__/spectral.test.ts
Outdated
| ({ | ||
| result: {}, | ||
| refMap: {}, | ||
| errors: [], |
There was a problem hiding this comment.
Let's avoid the type trickery here.
Add the following import
import { DepGraph } from 'dependency-graph';
and then you should be able to include graph
errors: [],
graph: new DepGraph(),There was a problem hiding this comment.
@P0lip My bad. It's now fixed.
P0lip
changed the title
P0lip
previously approved these changes
Oct 10, 2019
|
@P0lip Shouldn't we also explicitly bump the reference in |
|
Ah, yeah, we should do that. |
|
@nulltoken could you bump it? |
Bumps [@stoplight/json-ref-resolver](https://github.com/stoplightio/json-ref-resolver) from 2.2.0 to 2.3.0. - [Release notes](https://github.com/stoplightio/json-ref-resolver/releases) - [Commits](stoplightio/json-ref-resolver@v2.2.0...v2.3.0) Signed-off-by: dependabot-preview[bot] <[email protected]>
Bumped! |
P0lip
approved these changes
Oct 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed by #635
Checklist
Does this PR introduce a breaking change?
wrt "hacking the tests", this isn't the ideal way to do this, but as the they do not depend
on the newly introduced graph member, that should be enough.
Relevant context: