chore: drop support for Node 8 #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
P0lip
force-pushed
the
build/es2017-target
branch
from
74a994c
to
8735494
Compare
|
Normally I wouldn’t support removing tests on a version “for the sake of it” but if we are going to make develop v5 now then this is a good time to remove, otherwise we’d be forced to drop it as a v6 the first time a PR was struggling on v8. |
philsturgeon
approved these changes
Oct 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Node 8 is about to reach its end of life - https://nodejs.org/en/about/releases/
Users should not be really affected, as our code is likely to still be fully functional under Node 8, but we just won't support it officially anymore.