Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(tests): raise tests execution timeout to 10s #667

Merged
merged 3 commits into from
Oct 10, 2019
Merged

chore(tests): raise tests execution timeout to 10s #667

merged 3 commits into from
Oct 10, 2019

Conversation

nulltoken
Copy link
Contributor

Checklist

  • Tests added / updated
  • Docs added / updated

Does this PR introduce a breaking change?

  • Yes
  • No

Not everyone owns a beefy box. As a result, running the tests usually end up with a lot of errors like the one below

Timeout - Async callback was not invoked within the 
5000ms timeout specified by jest.setTimeout.

And, from time to time, even the CI server is a bit behind... ;-)

image

This change proposes to bump a bit the threshold in order to provide us with a bit of leeway.

Thoughts?

@P0lip
Copy link
Contributor

P0lip commented Oct 10, 2019

This change proposes to bump a bit the threshold in order to provide us with a bit of leeway.

Yeah, I'm fine with that if that improves the situation and avoids random failures.
IIRC we used to have 10s in the past, but I removed it.

@P0lip P0lip merged commit 016c286 into stoplightio:develop Oct 10, 2019
@nulltoken nulltoken deleted the ntk/bump_tests_timeout branch October 10, 2019 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants