breaking: bump default fail severity to warn #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philsturgeon
force-pushed
the
feat/bump-severity
branch
from
5745697
to
484cda8
Compare
philsturgeon
added
breaking
philsturgeon
changed the title
Co-Authored-By: Jakub Rożek <[email protected]>
|
@P0lip thanks! Can you re-approve and merge? :) |
P0lip
previously approved these changes
Oct 24, 2019
P0lip
force-pushed
the
feat/bump-severity
branch
from
29a3fe5
to
5bb2c2e
Compare
P0lip
approved these changes
Oct 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ever since the CLI was first added, the existence of any results whatsoever would trigger an exit code, even if they were only info or hint. Users have requested this be fixed several times, but we could not do it as part of #368 as it would have been a breaking change. Let's merge this, and develop will be the basis of v5.0 and any other breaking changes we have to make.