Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: improve Dependabot integration #862

Merged
merged 2 commits into from
Dec 18, 2019
Merged

Conversation

P0lip
Copy link
Contributor

@P0lip P0lip commented Dec 18, 2019

At the moment we try to update dependencies on a daily basis regardless of their type.
This causes a small disruption in case of certain packages, i.e. @types/* or rollup, as they are updated more frequently, therefore plenty of PRs are created.

github com_stoplightio_spectral_pulls_utf8=%E2%9C%93 q=is%3Apr+is%3Aclosed+rollup (1)

Developer dependencies do not need to updated that often, as we usually use a small subset of their functionality and don't use them directly in a production environment, therefore as long as our own developer experience is not affected or they don't come up a significant improvement, we don't need to check for updates daily.

Production dependencies, on the other hand, are usually more important, as they contain actual bugfixes or features impacting end users. Moreover, by performing regular updates, we are less prone to be affected by breaking changes, since deprecation notices are thrown at us more often allowing us to get rid of the deprecated part.

The PR makes all production packages to be checked in a live mode (PRs should be created as soon as the change is up). Besides that, all Stoplight packages are updated in that mode as well, no matter what their type is. Last but not least, all security updates coming from dev dependencies are checked in real-time too.

DevDependencies are scheduled to be updated on a weekly basis.


I hope I didn't screw the config 😅

@P0lip P0lip self-assigned this Dec 18, 2019
Copy link
Contributor

@philsturgeon philsturgeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing job. @XVincentX maybe you want something like this for Prism if Dependabot is bugging you.

@XVincentX
Copy link
Contributor

@philsturgeon Prism has already most of this stuff — the configuration is in the UI though, not in the dependabot file.

@P0lip
Copy link
Contributor Author

P0lip commented Dec 18, 2019

@XVincentX I tried using UI, but you cannot configure different schedules for dev and production dependencies. Or did I miss something? 🙈

@P0lip P0lip merged commit a4f0759 into develop Dec 18, 2019
@P0lip P0lip deleted the build/dependabot-config branch December 18, 2019 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants