-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: sqs based architecture data stack #44
Conversation
f02946d
to
371f45b
Compare
371f45b
to
32a42e6
Compare
32a42e6
to
f66e4b3
Compare
fbe661c
to
1004f1e
Compare
1004f1e
to
a794436
Compare
a794436
to
55e0028
Compare
55e0028
to
7d55806
Compare
7d55806
to
b1ac744
Compare
b1ac744
to
b2fbfc5
Compare
b2fbfc5
to
83f9c1f
Compare
const pieces = [] | ||
for (const b of bufferReferences) { | ||
// eslint-disable-next-line unicorn/prefer-spread | ||
pieces.concat(b.ok?.pieces || []) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
concat does not mutate any arrays it creates a new one so think this is not going to behave correctly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes good catch, these were the tests I still had in progress. Adding final commit that fixes it
83f9c1f
to
0ceb062
Compare
0ceb062
to
a3dd2a1
Compare
a3dd2a1
to
c0d3a5c
Compare
View stack outputs
|
@@ -282,7 +282,7 @@ function aggregatePieces (bufferedPieces, sizes) { | |||
return { | |||
addedBufferedPieces, | |||
remainingBufferedPieces, | |||
aggregate: aggregate.toInfo() | |||
aggregate: aggregate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aggregate: aggregate | |
aggregate |
Implements SQS based architecture for data stack based on proposed architecture
It also implements the aggregator spec role from storacha/specs#71 relying on filecoin-api and filecoin-client
Needs: