fix: spade oracle sync with log2size to height conversion #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
View stack outputs
|
Gozala
reviewed
Nov 14, 2023
| * @param {number} log2Size | ||
| */ | ||
| function log2PieceSizeToHeight (log2Size) { | ||
| return Piece.Size.Expanded.toHeight(BigInt(log2Size)) |
There was a problem hiding this comment.
Suggested change
| return Piece.Size.Expanded.toHeight(BigInt(log2Size)) | |
| return Piece.Size.Expanded.toHeight(BigInt(2n ** log2Size)) |
Gozala
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually assumption that
piece_log2_sizewas height was bad, which resulted in a mismatch on generated PieceCidv2 from PieceCidV1 we get from spade, which would not match to new deals for the dealer aggregates and receipts issuedNote that new bucket and DB are created given tear down the old DB and Bucket is way cheaper than running Dynamo delete commands for every single record in the table