vanilla js examples fail to build #243
Comments
olizilla
added a commit
that referenced
this issue
Jan 16, 2023
Pulls example tests out to own dir so we can run the same test for each ui library! fixes: #222 You can see it run in CI at https://github.com/web3-storage/w3ui/actions/runs/3901558574/jobs/6663550379#step:6:13 and you can try it out locally from this branch by running: ``` $ pnpm install # one time download of test browsers $ pnpx playwright install # fails for vanilla currently, but is ok, proceed. $ pnpm build:examples $ pnpm test:examples Scope: 20 of 33 workspace projects examples/test/playwright test$ playwright test [30 lines collapsed] │ [30/33] [webkit] › sign-up-in.spec.ts:4:3 › vue: sign in │ [31/33] [webkit] › uploads-list.spec.ts:4:3 › react: uploads list │ [32/33] [webkit] › uploads-list.spec.ts:4:3 › solid: uploads list │ [33/33] [webkit] › uploads-list.spec.ts:4:3 › vue: uploads list │ │ 33 passed (7s) │ To open last HTML report run: │ │ npx playwright show-report │ └─ Done in 7.6s ``` _note: the build fails currently as our vanilla examples fail to build currently, which is why we need these tests!_ Adds and updates run scripts to make it easy to run package or example tests. Most of the time we'd want to run package tests locally, so this is set as the default. ```bash # runs package tests $ pnpm test # builkd examples. must be run before test so the dist dir exits for each $ pnpm build:examples # run example test $ pnpm test:examples # serve examples, so you can poke around as a dev. $ pnpm serve:examples ``` Updates examples to produce relative URLs by setting `base: ''` in vite config. This allows us to serve all the examples from a single static server in the `examples` dir, and `serve` is added with a `serve.json` config to rewrite the paths so the `dist` dir is served for each example. Adds playwright config to fire up the example server Adds github workflow to set up and run the browser tests only if we make a change to the examples. We may change this to run for every change in the future, as we should probably check if the examples still work if we change a package! Reduces the scope of our local github action to just handle setting up node and pnpm which is needed by every workflow. `lint` and `test` are now specified explicitly in workflows that should run them. We don't need to run those steps when we're doing browser testing. - Vanilla JS examples are not currently tested as they fail to build #243 - we can fix in a separate PR. - We need a mechanism to be able to register a space from browser, or add pre-registered test account fixture - #244 - We are missing a `multi-file-upload` example - #245 <img width="707" alt="Screenshot 2023-01-12 at 02 03 41" src="https://user-images.githubusercontent.com/58871/211958353-b4a587a7-ead7-4957-b028-45b17c41f9a3.png"> <img width="1582" alt="Screenshot 2023-01-12 at 01 57 39" src="https://user-images.githubusercontent.com/58871/211957738-0bfad4e5-a0e4-4ba6-8a13-ee05602f3adc.png"> **whoo!** <img width="871" alt="Screenshot 2023-01-12 at 11 00 28" src="https://user-images.githubusercontent.com/58871/212049726-68f86951-c244-4ed3-bde9-4ca3bfaa25ca.png"> License: MIT Signed-off-by: Oli Evans <[email protected]> Signed-off-by: Oli Evans <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
While working on #242 I could not get the vanilla js examples to build. We want them to work good!
The text was updated successfully, but these errors were encountered: